Fix list of available OpenCL C standards
ClosedPublic

Authored by aaronpuchert on May 26 2017, 7:20 PM.

Details

Summary

OpenCL C is based on the C99 standard, but doesn't conform with it.
Instead there are dedicated OpenCL standards.

This is still not entirely correct, since OpenCL requires the standard
to be passed via -cl-std=... instead of -std=..., but fixing this
requires additional changes.

Diff Detail

Repository
R32 KDevelop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
aaronpuchert created this revision.May 26 2017, 7:20 PM
apol requested changes to this revision.May 27 2017, 3:14 PM
apol added a subscriber: apol.
apol added inline comments.
languages/plugins/custom-definesandincludes/kcm_widget/parserwidget.ui
214 ↗(On Diff #14864)

This doesn't look right, looks like you're removing the c++ entries.

This revision now requires changes to proceed.May 27 2017, 3:14 PM
aaronpuchert added inline comments.May 27 2017, 8:56 PM
languages/plugins/custom-definesandincludes/kcm_widget/parserwidget.ui
214 ↗(On Diff #14864)

It belongs to the <widget class="QComboBox" name="languageStandardsOpenCl"> starting in line 197 and ending in line 232 (227). The C++ options should remain unaffected.

@apol: Could you have a look again? I think there is nothing wrong here.

apol accepted this revision.May 29 2017, 11:59 PM
This revision is now accepted and ready to land.May 29 2017, 11:59 PM

If anyone cares, here is what the official documentation says on this matter. I want to address the -std= vs. -cl-std= issue in another commit.

Could someone commit this, as I'm not allowed to?

This revision was automatically updated to reflect the committed changes.