Always add data sources in SystemMonitorEngine::sourceRequestEvent()

Authored by elvisangelaccio on May 26 2017, 9:22 AM.



Otherwise if we show the plasma-nm applet twice, m_sensors won't be empty
and we won't be able to fect the connection speed data.

git blame points to

but they don't really explain why setData() was called only if m_sensors
was empty.

BUG: 380209

Test Plan
  • plasmoidviewer -a org.kde.plasma.networkmanagement
  • open the networkmanager applet twice
  • make sure the connection's speed graph works the 2nd time.

Diff Detail

R120 Plasma Workspace
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
Restricted Application added a project: Plasma. · View Herald TranscriptMay 26 2017, 9:22 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
elvisangelaccio edited the test plan for this revision. (Show Details)May 26 2017, 9:23 AM
davidedmundson accepted this revision.May 26 2017, 9:31 AM
This revision is now accepted and ready to land.May 26 2017, 9:31 AM
This revision was automatically updated to reflect the committed changes.