Differential D5960

Expose information to Qt metaobject system
ClosedPublic
Actions

Authored by apol on May 24 2017, 3:08 PM.

Tags

None

Subscribers

Details

Reviewers

Commits

R849:50a8ad265704: Expose information to Qt metaobject system

Summary

So that it can be integrated in QtQuick applications

Test Plan

Implemented it Discover, everything seems to work

Diff Detail

Repository

R849 User Feedback Collection Framework

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

apol created this revision.May 24 2017, 3:08 PM

vkrause accepted this revision.May 24 2017, 5:34 PM

This revision is now accepted and ready to land.May 24 2017, 5:34 PM

Closed by commit R849:50a8ad265704: Expose information to Qt metaobject system (authored by apol). · Explain WhyMay 24 2017, 8:31 PM

This revision was automatically updated to reflect the committed changes.

kfunk added a subscriber: kfunk.Jun 2 2017, 2:34 PM

kfunk added inline comments.

src/provider/core/surveyinfo.cpp
103	@apol: I don't get why this is needed? You'd need to include "foo.moc" in case there's a QObject-derived class in the .cpp file -- isn't the case here. Can we just remove?

@apol: I don't get why this is needed? You'd need to include "foo.moc" in case there's a QObject-derived class in the .cpp file -- isn't the case here.
Can we just remove?

My reasoning was that maybe Qt 4 would choke on Q_GADGET. If you think it won't hurt, feel free to remove it.

Revision Contents
Changeset List

			Path	Packages
M			src/provider/core/provider.h (4 lines)
M			src/provider/core/surveyinfo.h (13 lines)
M			src/provider/core/surveyinfo.cpp (4 lines)
M			tests/CMakeLists.txt (2 lines)

Diff 14823

src/provider/core/provider.h

Loading...

src/provider/core/surveyinfo.h

Loading...

src/provider/core/surveyinfo.cpp

Loading...

tests/CMakeLists.txt

Loading...