Differential D5950

Implement the new panel icon size ceiling also for Activities.
ClosedPublic
Actions

Authored by hein on May 23 2017, 10:35 PM.

Details

Reviewers
mart
broulik
Group Reviewers
Plasma
Commits
R119:a8d9038a592e: Implement the new panel icon size ceiling also for Activities.
Summary

It was done for various other applets but not this.

BUG:378443

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
hein created this revision.May 23 2017, 10:35 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMay 23 2017, 10:35 PM
hein added a comment.May 23 2017, 10:37 PM
NOTE: We are tagging 5.10 very soon. If this is accepted (and it should be, as it is in plasma-desktop and we're advertising this in the release notes) and I am for some reason unavailable and not doing it, please make sure and take care of pushing this into the 5.10 branch before tagging.
broulik accepted this revision.May 23 2017, 10:39 PM
This revision is now accepted and ready to land.May 23 2017, 10:39 PM
Closed by commit R119:a8d9038a592e: Implement the new panel icon size ceiling also for Activities. (authored by hein). · Explain WhyMay 23 2017, 11:42 PM
This revision was automatically updated to reflect the committed changes.
ivan added a subscriber: ivan.May 24 2017, 5:20 AM

It would be nicer if we had a better way to do this instead of having a chunk of code copy-pasted all over the place.

mvourlakos added a subscriber: mvourlakos.May 24 2017, 6:52 AM

Just to add that because of this way of implementation all plasmoids are bound totally to plasma design decisions and cant be used elsewhere e.g. Latte. So the plasmoids are bound to plasma paradigm.

I hope only that the user will be able to set the panel iconsizehints to greater values than the icon theme provides, at least by editing manually the plasma files...

mart edited edge metadata.May 24 2017, 8:56 AM
In D5950#111479, @mvourlakos wrote:

I hope only that the user will be able to set the panel iconsizehints to greater values than the icon theme provides, at least by editing manually the plasma files...

this depends from a value manually set in the icons kcm, so can be set to anything

mart reopened this revision.May 24 2017, 9:01 AM
mart added inline comments.
applets/showActivityManager/package/contents/ui/main.qml
31

to detect if this is in a panel was intended from the beginning the formfactor, not the location

37

this will break fitts law on an horizontal panel, as mouse wouldn't work on screen edge?

This revision is now accepted and ready to land.May 24 2017, 9:01 AM
hein added inline comments.May 24 2017, 3:39 PM
applets/showActivityManager/package/contents/ui/main.qml
31

We've had this discussion on IRC before and you agreed with my reasoning as well as saying "it doesn't matter". Do you want to reopen this discussion now that the code is in ~10 places ...?

37

It works fine.

hein added a comment.May 24 2017, 3:41 PM
In D5950#111476, @ivan wrote:

It would be nicer if we had a better way to do this instead of having a chunk of code copy-pasted all over the place.

Agreed. Any ideas? Maybe we can implement it in IconItem somehow ...

hein closed this revision.May 30 2017, 7:08 AM

This was committed as a8d9038a592e6d3ed87852bc2fb3a0f93449897d, not sure why the ticket didn't get closed.

Revision Contents
Changeset List

Diff 14791

View Options

applets/showActivityManager/package/contents/ui/main.qml

Loading...