It was done for various other applets but not this.
BUG:378443
Details
Details
- Reviewers
mart broulik - Group Reviewers
Plasma - Commits
- R119:b45cb75675c9: Implement the new panel icon size ceiling also for Kickoff.
Diff Detail
Diff Detail
- Repository
- R119 Plasma Desktop
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
NOTE: We are tagging 5.10 very soon. If this is accepted (and it should be, as this is the default launcher, and this is a feature we're advertising in the release notes) and I am for some reason unavailable and not doing it, please make sure and take care of pushing this into the 5.10 branch before tagging.
Comment Actions
Can you verify that a thick (vertical) panel still gives you an expanded Kickoff? That was the reason I didn't implement this for FolderView.
Comment Actions
It doesn't, and so far the consensus on Plasma when discussing this has been that we care more about fixing the usual vertical panel use case than a Kickoff sidebar. It's probably also good for Latte Dock where they have problems with the parabolic zoom causing repr switches.
Comment Actions
Thx for the accept.
I think it may be possible to write smarter code that does something like "look at the switchWidth/switchHeight, and if without the size limit they would be reached, drop the limit" or something ... and manage the content and the layout sizes indepedently for it. I think we should try to fix this better for 5.11 for sure.
Comment Actions
Indeed, might need a concept of some softer limit, so it won't grow the icon (which is what we're trying here) but still has it expand above a given threshold. I don't think Kickoff was that usable (or nice to look at, rather) in a sidebar panel, so fine with me on 5.10.
Btw show desktop (on the default panel setup too I think) and minimize all might also need similar treatment.
Comment Actions
They seem to use the default compact repr and already work.
Trickier question is what to do about Folder View, and also Kimpanel is really broken still and a lot more complex to fix.