Added a new menu item to reset the RSIBreak timer.
Tested with RSIBreak v0.11 with KDE4 [with appropriate modifications] but not with KF5.
aacid |
Added a new menu item to reset the RSIBreak timer.
Tested with RSIBreak v0.11 with KDE4 [with appropriate modifications] but not with KF5.
Lint Skipped |
Unit Tests Skipped |
I'm not convinced about the use of media-eject icon.
What's your rationale for using it?
Ah, it was just an easy choice with the play/pause next to it on 'Suspend'. If there is a more appropriate Icon, feel free to change it!
What is your usecase for Reset Timer?
I find it clutters the menu by adding an extra option that i don't see why I would ever want to use.
I was taking my lead from http://goodies.xfce.org/projects/panel-plugins/xfce4-time-out-plugin which I use on my XFCE platforms, which has .. Different .. functionality to the KDE plugin! I don't believe the XFCE variant properly manages the screensaver and idle events, so possibly the 'Reset' and 'Take Break' manual options better fit that scenario than the KDE one. HTH.
Not really, i mean you explained why the xfce plugin needs it, because it doesn't take idles by itself, so you need to do it manually.
Now, please explain why would you need to manually reset rsibreak with its current functionality