We should not forget the launchers that are not currently shown
ClosedPublic

Authored by ivan on May 22 2017, 8:11 AM.

Details

Summary

The pinned launchers that are assigned to other activities
will have a -1 as the order. We should not forget them
when saving to the configuration file.

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ivan created this revision.May 22 2017, 8:11 AM
Restricted Application added a project: Plasma. · View Herald TranscriptMay 22 2017, 8:11 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ivan added a comment.May 22 2017, 8:15 AM

This is meant to fix the https://bugs.kde.org/show_bug.cgi?id=379414

Currently, the ordering of pinned tasks is not independent between activities - that would require more intrusive changes not really desired this late in the release cycle (changes to the configuration file).

Tested reordering of tasks pinned to a single or multiple activities.

hein accepted this revision.May 22 2017, 10:16 AM

Yay!

This revision is now accepted and ready to land.May 22 2017, 10:16 AM
This revision was automatically updated to reflect the committed changes.
hein added a comment.May 24 2017, 3:47 PM

Is there a reason why this wasn't committed to the 5.10 branch yet? This is a critical fix and we're tagging tomorrow.

hein added a comment.May 24 2017, 8:51 PM

Since I'm not available on tagging day and was concerned about missing this fixed, I put it into the 5.9 and 5.10 branches myself now.