improve positioning for highlight in systray
ClosedPublic

Authored by mvourlakos on May 20 2017, 11:38 AM.

Details

Summary

--the highlight item used in the systray now uses
the panel thickness for correct positioning. In
the past there were cases that the highlight item
wasnt shown at all or was positioned a bit far from
the panel edge

Test Plan

use the systray and investigate that highlight item
is positioned correctly

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mvourlakos created this revision.May 20 2017, 11:38 AM
Restricted Application added a project: Plasma. · View Herald TranscriptMay 20 2017, 11:38 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

Before:

After:

mart edited edge metadata.May 22 2017, 8:54 AM

this will break for multi-line systrays

mart requested changes to this revision.May 22 2017, 8:56 AM

can you make the panel taller and send a screenshot of how it looks then with different items highlighted?

This revision now requires changes to proceed.May 22 2017, 8:56 AM
In D5927#111140, @mart wrote:

this will break for multi-line systrays

makes sense, in multi line systray the active applet shouldnt be indicated correctly...

I can follow two paths,

  1. stinguish the multi line case and in such case for applets to use the old way and for root the new
  1. use 1. also for the single line systray,

what do you propose?

mart added a comment.May 22 2017, 9:32 AM
In D5927#111140, @mart wrote:

this will break for multi-line systrays

makes sense, in multi line systray the active applet shouldnt be indicated correctly...

I can follow two paths,

  1. stinguish the multi line case and in such case for applets to use the old way and for root the new
  2. use 1. also for the single line systray,

    what do you propose?

logic should remain as it was, but perhaps using a negative margin to compensate

mvourlakos updated this revision to Diff 14766.May 22 2017, 7:01 PM
mvourlakos edited edge metadata.

Updating D5927: improve positioning for highlight in systray

--fixed the issue mentioned for multirow case

@mart the last commit fixes the multirow behavior and also this topic

(fixed issue of line positioning)

(fixed issue of multirow behavior from initial commit and behavior is identical to master)


(wrong master behavior1, no line is shown even though it should)

(current master behavior for multirow to compare with current commit)

mart accepted this revision.May 23 2017, 12:09 PM
This revision is now accepted and ready to land.May 23 2017, 12:09 PM
This revision was automatically updated to reflect the committed changes.