Remove filename from source/dest fields in job notification
Needs ReviewPublic

Authored by droserasprout on May 20 2017, 11:33 AM.

Details

Reviewers
None
Group Reviewers
Plasma

Diff Detail

Repository
R120 Plasma Workspace
Lint
Lint Skipped
Unit
Unit Tests Skipped
droserasprout created this revision.May 20 2017, 11:33 AM
Restricted Application edited projects, added Plasma; removed Plasma: Workspaces. · View Herald TranscriptMay 20 2017, 11:33 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

Why?

This way it's easier to track progress of jobs with long paths IMO.

...and we have the filename just above it, making this duplicate information.
Kinda makes sense then.

Can we you do this in kuiserverengine.cpp instead?

I think it's fine in this place (not kuiserverengine), I suppose slice(0,0) will return the entire string so this won't break cases where we do not have a path?

Can we perhaps extend this so when the filename of the destination is the same as the filename in the source (the most common case) that we also remove it?