Differential D5898

Setup packing AtCore
ClosedPublic
Actions

Authored by laysrodrigues on May 17 2017, 1:17 AM.

Details

Reviewers
vonreth
Commits
R138:4aa8f99ee759: Setup packing AtCore
R138:606e0e335c8a: Setup packing AtCore
Summary

Based on Kate setup for NSIS packing, I did this
one for AtCore.

  • Add Icon
  • Add blacklist.txt
  • Update atcore recipe

Signed-off-by: Lays Rodrigues <laysrodriguessilva@gmail.com>

Diff Detail

Repository
R138 Craft
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
laysrodrigues created this revision.May 17 2017, 1:17 AM
vonreth requested changes to this revision.May 17 2017, 10:18 AM

Please have a closer look of the definition of class Package in this recipe.
And try to run your code 😜

portage/extragear/atcore/atcore.py
16–17

make sure to depend on lib/runtime to make sure the mingw runtime is packaged.

27

pls use self.packageDir() instead of os.path.dirname(file)

34

self.packageDir()

portage/extragear/atcore/atelier.ico
1

nsis tells me the icon is invalid.
pls try to use png2ico to create the icon.

portage/extragear/atcore/blacklist.txt
65

maybe you would like to adjust your blacklist to alow AtCoreTestClient.exe ?

This revision now requires changes to proceed.May 17 2017, 10:18 AM
laysrodrigues updated this revision to Diff 14652.May 18 2017, 1:57 AM
laysrodrigues edited edge metadata.
  • Fix issues
laysrodrigues marked 2 inline comments as done.May 18 2017, 1:58 AM

I'm going to test again the packaDir, but iirc didn't work yesterday.

laysrodrigues updated this revision to Diff 14689.May 19 2017, 12:57 PM
  • Final Adjusts
vonreth accepted this revision.May 19 2017, 3:06 PM

pls push to master and cherry-pick -x to 2017.05

This revision is now accepted and ready to land.May 19 2017, 3:06 PM
Closed by commit R138:606e0e335c8a: Setup packing AtCore (authored by laysrodrigues). · Explain WhyMay 20 2017, 3:40 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 14703

View Options

portage/extragear/atcore/atcore.py

Loading...
View Options

portage/extragear/atcore/atelier.ico

Loading...
View Options

portage/extragear/atcore/blacklist.txt

Loading...