Replace Radioboxes for Absolute and Relative mode selection with the printerhost position visual controller
Details
Details
Diff Detail
Diff Detail
- Repository
- R232 AtCore
- Branch
- betterMove
- Lint
No Linters Available - Unit
No Unit Test Coverage
Comment Actions
Can I finish my review this night ?
| testclient/mainwindow.cpp | ||
|---|---|---|
| 571–576 | space between brackets | |
Comment Actions
- Added Lays Printerhost Position Visual Controller.
- Replace Radioboxes for Absolute and Relative mode selection with the printerhost position
Comment Actions
- Added Lays Printerhost Position Visual Controller.
- Replace Radioboxes for Absolute and Relative mode selection with the printerhost position
- Make lable placement more dynamic to be more forgiving on various dpis
Comment Actions
- Added Lays Printerhost Position Visual Controller.
- Replace Radioboxes for Absolute and Relative mode selection with the printerhost position
- Make label placement more dynamic to be more forgiving on various dpis
- rebase to master
| testclient/widgets/axiscontrol.cpp | ||
|---|---|---|
| 88 | style script is run before every commit | |
| 103 | I can't speak for @tcanabrava , but I would say its there because its only done once at creation and since its not called more then that there is really no reason to put it in a function . Doing so makes the readability a bit harder because you have to stop reading there and go find the tiny function read that then go back to where you were . | |
| 128 | Sytle script "corrects" it to what you see | |
Comment Actions
- Added Lays Printerhost Position Visual Controller.
- Replace Radioboxes for Absolute and Relative mode selection with the printerhost position
- Make label placement more dynamic to be more forgiving on various dpis
- Rename printerhostpositionvisualcontroller to axiscontrol
- Respect the system palette
- Remove unneeded includes of QList and QResizeEvent and The unused event varibles
- rename dockWidgetContents_5 to moveDockContents