Differential D5858

Plugin Temperature Fix: Teacup Plugin
AbandonedPublic
Actions

Authored by rizzitello on May 14 2017, 9:11 PM.

Details

Reviewers
laysrodrigues
patrickelectric
tcanabrava
Summary

Check what kind of message teacup is sending back for temperature and try to correctly evaluate it

Diff Detail

Repository
R232 AtCore
Branch
fixTeacupTemp
Lint
No Linters Available
Unit
No Unit Test Coverage
rizzitello updated this revision to Diff 14523.May 14 2017, 9:11 PM
rizzitello created this revision.

-signed commit

rizzitello added a comment.May 14 2017, 9:12 PM

Tested and working on my teacup version T:180.4/180 B:60.6/60

rizzitello added reviewers: laysrodrigues, patrickelectric, tcanabrava.May 14 2017, 9:13 PM
rizzitello added a project: Atelier: AtCore.
rizzitello edited the summary of this revision. (Show Details)
patrickelectric added inline comments.May 14 2017, 9:14 PM
src/plugins/teacupplugin.cpp
58–59

I think that is a else if

rizzitello updated this revision to Diff 14525.May 14 2017, 9:16 PM
rizzitello edited the summary of this revision. (Show Details)
  • Merge: Remove duplcate log entries for no serial device
  • Fix Teacup Plugins temperature detection to work for both known reporting methods
rizzitello added inline comments.May 14 2017, 9:18 PM
src/plugins/teacupplugin.cpp
58–59

we enter this if bed temp then like above based on if there is a / in the string we parse one way or the other

rizzitello updated this revision to Diff 14527.May 14 2017, 9:21 PM

Change backwards target/ and current display

rizzitello retitled this revision from Fix Teacup Plugins temperature detection to work for both known reporting methods to Plugin Temperature Fix: Teacup Plugin.May 15 2017, 1:04 PM
rizzitello updated this revision to Diff 14683.May 19 2017, 3:41 AM
  • Check list 1 for string lens on list 1
rizzitello abandoned this revision.May 23 2017, 12:31 AM

This Will be resolved by T6165's resolution when implimented

Revision Contents
Changeset List

PathPackages
Msrc/plugins/teacupplugin.cpp (25 lines)

Diff 14683

View Options

src/plugins/teacupplugin.cpp

Loading...