fix plasma-frameworks build without kwayland
ClosedPublic

Authored by winterz on May 13 2017, 2:06 PM.

Details

Reviewers
mart
davidedmundson
bshah
Group Reviewers
Plasma
Summary

fixes the compile errors in plasmaquick/dialog.cpp if you don't have kwayland

Test Plan

compile it

Diff Detail

Repository
R242 Plasma Framework (Library)
Lint
Lint Skipped
Unit
Unit Tests Skipped
winterz created this revision.May 13 2017, 2:06 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptMay 13 2017, 2:06 PM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript
apol added a subscriber: apol.May 13 2017, 10:15 PM
apol added inline comments.
src/plasmaquick/dialog.cpp
1141

Maybe we should only wrap this one function call?

dfaure added a subscriber: dfaure.Jun 3 2017, 7:50 PM

Ping? This was reported by the packagers for KF5.35 as a build error, and it seems the patch just needs review/approval.

dfaure added inline comments.
src/plasmaquick/dialog.cpp
1141

The error message is dialog.cpp:1166:17: error: ‘class PlasmaQuick::DialogPrivate’ has no member named ‘shellSurface’, so no.

bshah accepted this revision.Jun 5 2017, 11:02 AM
This revision is now accepted and ready to land.Jun 5 2017, 11:02 AM

Still for 2nd review, adding Plasma as reviewer

davidedmundson accepted this revision.Jun 5 2017, 11:06 AM
mart accepted this revision.Jun 5 2017, 11:09 AM