include directory should contains all directory from pkg-config
AbandonedPublic

Authored by xuetianweng on May 11 2017, 3:41 AM.

Details

Reviewers
apol
aacid
Summary

For certain pkg-config file that depends on other pkg-config, e.g. pango
depends on glib2, glib's include directory would be omitted from the target,
which essentially make it useless since the target will not compile with
the only directory that contains the specified header.

Diff Detail

Repository
R240 Extra CMake Modules
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
xuetianweng created this revision.May 11 2017, 3:41 AM
Restricted Application added projects: Frameworks, Build System. · View Herald TranscriptMay 11 2017, 3:41 AM
Restricted Application added subscribers: Build System, Frameworks. · View Herald Transcript
apol requested changes to this revision.May 27 2017, 3:16 PM

Is there a way where we can include a test to make sure this works properly?

This revision now requires changes to proceed.May 27 2017, 3:16 PM
xuetianweng abandoned this revision.Nov 3 2017, 5:25 PM

Just noticed that FindPkgConfig has import_module now.. Personally I just port my code to use that.

Anyone who more familiar with test cmake script may take over this.