ContextBrowserPlugin: fix using selection foreground for search highlights
AbandonedPublic

Authored by cullmann on May 10 2017, 10:55 PM.

Details

Reviewers
brauch
intelfx
Group Reviewers
KTextEditor
Kate
KDevelop
Summary

This is not an actual pull-request but rather an RFC (request for comments) from
the KTextEditor, Kate and KDevelop developers, because I failed to solicit any
feedback on the kdevelop-devel@ and kwrite-devel@ mailing lists.

(http://kde.6490.n7.nabble.com/Properly-porting-Solarized-to-Kate-KDevelop-need-to-change-behavior-of-search-result-highlighting-td1655274.html)

While trying to make an exact port of Solarized to Kate/KDevelop (more details in
D5802), I've noticed a possible behavior-changing bug in context browser plugin.

(https://phabricator.kde.org/D5802)

The code seems to hint at using selection foreground for use-highlighted regions,
but uses normal foreground instead (which incidentally falls in line with behavior
for all other highlighting). I could just change it to avoid this uncertainty,
but the hinted-at behavior is what I want for Solarized.

Diff Detail

Repository
R33 KDevPlatform
Branch
selection-foreground-for-search-highlights
Lint
No Linters Available
Unit
No Unit Test Coverage
intelfx created this revision.May 10 2017, 10:55 PM
Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptMay 10 2017, 10:55 PM

I think like for the other request, we should keep the status quo ATM.

cullmann commandeered this revision.Dec 8 2018, 5:33 PM
cullmann added a reviewer: intelfx.

As nobody will be working on this, I abandon this now.
If somebody steps up to do the work, feel free to reopen it again.

cullmann abandoned this revision.Dec 8 2018, 5:33 PM