Details

Reviewers

laysrodrigues
patrickelectric
tcanabrava

Commits

R232:6b441cda29e3: Connect menu actions and insert dock view toggle actions
R232:6870a66318e7: Add new actions and remove the old unused ones
R232:cefffc2566b8: Revert "Use KXMLGui on MainWindow"

Summary

Removed dependency on KXMLGUI

Diff Detail

Repository

R232 AtCore

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

rizzitello created this revision.May 8 2017, 9:28 PM

rizzitello added reviewers: laysrodrigues, patrickelectric, tcanabrava.May 8 2017, 9:33 PM

rizzitello added a subscriber: Atelier: AtCore.

Try to use git revert, it's better to do this

Revert "Use KXMLGui on MainWindow"
Add new actions and remove the old unused ones
Connect menu actions and insert dock view toggle actions

patrickelectric requested changes to this revision.May 9 2017, 11:55 AM

patrickelectric added inline comments.

README.md
1 ↗	(On Diff #14330)	Something is wrong, please rebase your branch
testclient/mainwindow.h
180–181	Rebase

This revision now requires changes to proceed.May 9 2017, 11:55 AM

ReAttempt rebase

Clean a few unintended minimumSizes changes from the ui file

Fix a few more unintended ui changes

Closed by commit R232:cefffc2566b8: Revert "Use KXMLGui on MainWindow" (authored by rizzitello). · Explain WhyMay 10 2017, 12:55 AM

This revision was automatically updated to reflect the committed changes.

		Path
M		testclient/CMakeLists.txt (10 lines)
D	M	testclient/atcoreui.rc (24 lines)
M		testclient/main.cpp (36 lines)
M		testclient/mainwindow.h (4 lines)
M		testclient/mainwindow.cpp (30 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	14319	ed97b02		May 8 2017, 9:28 PM	★	★
Diff 2	14330	fdf3292	- Revert "Use KXMLGui on MainWindow"	May 9 2017, 2:31 AM	★	★
Diff 3	14354	a07cb0a	- ReAttempt rebase	May 9 2017, 10:25 PM	★	★
Diff 4	14356	a07cb0a	- Clean a few unintended minimumSizes changes from the ui file	May 9 2017, 11:16 PM	★	★
Diff 5	14357	a07cb0a	- Fix a few more unintended ui changes	May 9 2017, 11:19 PM	★	★
Diff 6	14359	a07cb0a	R232:cefffc2566b8fab264a47dab599f8e1049afbe8f	May 9 2017, 2:28 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
6b441cda29e3	0c3d90f7ebe3	6870a66318e7	Chris Rizzitello	Connect menu actions and insert dock view toggle actions (Show More…)	May 9 2017, 2:25 AM
6870a66318e7	28ae4f19da64	cefffc2566b8	Chris Rizzitello	Add new actions and remove the old unused ones (Show More…)	May 9 2017, 2:24 AM
cefffc2566b8	42d638fa3c81	a07cb0aedbaa	Chris Rizzitello	Revert "Use KXMLGui on MainWindow" (Show More…)	May 9 2017, 1:32 AM

Remove the dependency on KXMLGui
ClosedPublic
Actions

Details

Diff Detail

Revision Contents
Changeset List

Diff 14359

testclient/CMakeLists.txt

testclient/atcoreui.rc

testclient/main.cpp

testclient/mainwindow.h

testclient/mainwindow.cpp

Remove the dependency on KXMLGuiClosedPublicActions

Details

Diff Detail

Revision ContentsChangeset List

Diff 14359

testclient/CMakeLists.txt

testclient/atcoreui.rc

testclient/main.cpp

testclient/mainwindow.h

testclient/mainwindow.cpp

Remove the dependency on KXMLGui
ClosedPublic
Actions

Revision Contents
Changeset List