Show a lock icon for Locked tabs

Authored by abika on May 8 2017, 5:48 PM.



Removed unused signal for adjusting panel path label
Became obsolete with changing panel origin bar to KUrlNavigator.

Added icon to locked tabs

+ cleanup and style fixes.

Test Plan
  • lock&unlock :)
  • open profile with locked tabs
  • open profile with locked tabs on startup

Diff Detail

R167 Krusader
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
abika created this revision.May 8 2017, 5:48 PM
abika edited the summary of this revision. (Show Details)May 8 2017, 5:52 PM
martinkostolny accepted this revision.May 8 2017, 8:23 PM
martinkostolny added a subscriber: martinkostolny.

This is perfect! I also wanted to visualize the locked state but couldn't figure out how. This is a very elegant solution. Thanks!

I was testing with the D5744 already applied so I've got an issue with some profiles. When existing tab is locked and a the same tab is recreated from a profile (not locked), the "locked" icon stays. And vice versa. This (applied on top of your changes) should fix that:

diff --git a/krusader/panelmanager.cpp b/krusader/panelmanager.cpp
index 19044158..ae97497f 100644
--- a/krusader/panelmanager.cpp
+++ b/krusader/panelmanager.cpp
@@ -206,6 +206,7 @@ void PanelManager::loadSettings(KConfigGroup config)
         ListPanel *panel = i < numTabsOld ? _tabbar->getPanel(i) : addPanel(false, grpTab);
+        _tabbar->updateTab(panel);
     for(int i = numTabsOld - 1; i >= numTabsNew && i > 0; i--)
This revision is now accepted and ready to land.May 8 2017, 8:23 PM
Closed by commit R167:4aff0a4f24e6: Merge branch 'my-lock_icon' (authored by Alexander Bikadorov <>). · Explain WhyMay 10 2017, 6:37 PM
This revision was automatically updated to reflect the committed changes.
abika added a comment.May 10 2017, 6:38 PM

Thanks Martin! Not a surprise I missed something again during testing:/

I added the line to the commit.