speed up detail treeview display by avoiding too many column resizes
ClosedPublic

Authored by mkoller on May 8 2017, 5:42 PM.

Details

Summary

This patch basically delays the connect to the layoutChanged model signal until it emits its completed() signal.
Therefore the many calls for the expensive expandNameColumn() method are avoided.

This fixes bug https://bugs.kde.org/show_bug.cgi?id=346403
(how to define this bug to be related in phabricator I don't know)

Test Plan

kdialog --getsavefilename /tmp
where my /tmp is not really large (~570 files)

Diff Detail

Repository
R241 KIO
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mkoller created this revision.May 8 2017, 5:42 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptMay 8 2017, 5:42 PM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript
dfaure accepted this revision.May 13 2017, 12:19 PM

I don't really know this code, but I definitely welcome such very needed speed improvements.

src/filewidgets/kdiroperatordetailview.cpp
156

Is there any risk that this connect is done multiple times?

This revision is now accepted and ready to land.May 13 2017, 12:19 PM
mkoller added inline comments.May 13 2017, 12:38 PM
src/filewidgets/kdiroperatordetailview.cpp
156

To be honest, I don't know. I'll add Qt::UniqueConnection just to be safe

This revision was automatically updated to reflect the committed changes.