This adds support for images hosted on http(s) remotes to the DesktopIcon item. It uses the qnam from the qqmlengine the item is associated with to do the fetching (and supports redirection, and will prefer cached images when available).
Details
Details
Used in Discover, where the QIconItem can, with this code, be replaced with DesktopIcon items.
Diff Detail
Diff Detail
- Repository
- R169 Kirigami
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
That's already covered in DesktopIcon::updatePaintNode's big switch statement, where it checks for what type is actually inside m_source (heh, i thought it was in the patch, but that whole switch statement's not changed in the end) :) https://cgit.kde.org/kirigami.git/tree/src/desktopicon.cpp#n256
| src/desktopicon.cpp | ||
|---|---|---|
| 366 | coding style, space between if and ( | |