Removal of KDELibs4Support means own copy of FindSamba.cmake needed
ClosedPublic

Authored by marten on May 8 2017, 10:26 AM.

Details

Summary

This CMake module used to be provided by KDELibs4Support. Since the removal of that dependency from kio-extras, the module is not found and the SMB ioslave cannot be built.

This differential takes a local copy of the module from KDELibs4Support in kio-extras. No other part of KDE frameworks or Plasma appears to need Samba, therefore this approach should be preferable to copying it into ECM.

Test Plan

Copied this file into kio-extras/cmake source directory and built.
Samba libraries (from Samba 4.2.14) are found, and the SMB ioslave is built and works correctly.

Diff Detail

Repository
R320 KIO Extras
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
marten created this revision.May 8 2017, 10:26 AM
Restricted Application added a project: Plasma. · View Herald TranscriptMay 8 2017, 10:26 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
lbeltrame accepted this revision.May 11 2017, 7:27 AM
lbeltrame added a subscriber: lbeltrame.

This breaks the SMB ioslave, so please commit at the earliest. Thanks!

This revision is now accepted and ready to land.May 11 2017, 7:27 AM
lbeltrame requested changes to this revision.EditedMay 11 2017, 7:34 AM

Sorry, I have to backtrack. You need to add also COPYING-CMAKE-SCRIPTS to this commit, if it's not in the repository already, or there won't be any reference to the license.

This revision now requires changes to proceed.May 11 2017, 7:34 AM
fvogt added a subscriber: fvogt.May 11 2017, 7:45 AM

Sorry, I have to backtrack. You need to add also COPYING-CMAKE-SCRIPTS to this commit, if it's not in the repository already, or there won't be any reference to the license.

Sorry, I'm not yet familiar with that and can't find any documented reference. Do you mean simply add a copy of the extra-cmake-modules/COPYING-CMAKE-SCRIPTS file in the cmake subdirectory (alongside the new FindSamba.cmake)?

Sorry, I have to backtrack. You need to add also COPYING-CMAKE-SCRIPTS to this commit, if it's not in the repository already, or there won't be any reference to the license.

Sorry, I'm not yet familiar with that and can't find any documented reference. Do you mean simply add a copy of the extra-cmake-modules/COPYING-CMAKE-SCRIPTS file in the cmake subdirectory (alongside the new FindSamba.cmake)?

Yup, exactly that

This revision was automatically updated to reflect the committed changes.