client requests to toggle those states, to be used by libtaskmanager
Details
Details
- Reviewers
hein graesslin - Group Reviewers
Plasma Plasma on Wayland - Commits
- R127:e8e88174571c: add requestToggleKeepAbove/below
setting keep above from the taskbar works
Diff Detail
Diff Detail
- Repository
- R127 KWayland
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
| src/client/plasmawindowmanagement.h | ||
|---|---|---|
| 413 | All these need @since | |
Comment Actions
You also still need to extend PlasmaWindowModel and the unit tests. Everywhere in the kwayland codebase requestToggleMinimized pops up should also have a codepath for these new ones.
Comment Actions
isn't it covered by
QTest::newRow("keepAbove") << &PlasmaWindowInterface::keepAboveRequested << int(ORG_KDE_PLASMA_WINDOW_MANAGEMENT_STATE_KEEP_ABOVE);
QTest::newRow("keepBelow") << &PlasmaWindowInterface::keepBelowRequested << int(ORG_KDE_PLASMA_WINDOW_MANAGEMENT_STATE_KEEP_BELOW);what do i need to add?
Comment Actions
no, that is a test for the Model. The test for the actual interface is in test_wayland_windowmanagement. That test goes more into the detail of how the interface works. Things we cannot test with the test for the model which only can cover one specific branch.
Comment Actions
Martin, did you mix things up here maybe? The patch has changes to autotests/client/test_wayland_windowmanagement.cpp. The "newRow" bit isn't related to QAIM. It's a row of test data.
Comment Actions
Well my point was that the patch does add code to both tests (modulo the things you asked to be extended now).