Depends on D5747.
Details
Details
- Reviewers
davidedmundson sebas graesslin - Group Reviewers
Plasma - Commits
- R120:140c65f2236b: Expose PlasmaWindow::pid through WaylandTasksModel.
Diff Detail
Diff Detail
- Repository
- R120 Plasma Workspace
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage
Comment Actions
Commit embargo till 5.10 is branched.
libtaskmanager/waylandtasksmodel.cpp | ||
---|---|---|
340 | You are aware that pid is not always correct? Any process started by KWin shares KWin pid. Given that one need to be careful outside of KWin. You should not base any decisions on it and especially not try to close apps based on pid. |
Comment Actions
Argh, the lack of sleep ... I updated the wrong Phab. Give me a few mins ;)
libtaskmanager/waylandtasksmodel.cpp | ||
---|---|---|
340 | Yeah, I'm aware based on how ClientConnection must work. I'll enhance the AppPid role apidox in the abstract model. It's fine with how it's being used currently. |