Port more deprecated functions and fix warnings
ClosedPublic

Authored by rkflx on May 7 2017, 8:45 PM.

Details

Summary

KFileItem(mode, permissions, ...) is deprecated.
Port deprecated KRun::run to KRun:runService.
Replace deprecated std::auto_ptr with std::unique_ptr.
Add Q_DECL_OVERRIDE to MainWindow::eventFilter.

Depends on D5750
Depends on D5751

Test Plan

Tests pass.

Diff Detail

Repository
R260 Gwenview
Lint
Lint Skipped
Unit
Unit Tests Skipped
rkflx created this revision.May 7 2017, 8:45 PM
gateau accepted this revision.May 14 2017, 8:01 PM
This revision is now accepted and ready to land.May 14 2017, 8:01 PM
ltoscano edited edge metadata.May 14 2017, 8:08 PM

I can commit it; can we agree that it can go to master and not on Applications/17.04 (not strictly bugfix)? Or...?

rkflx added a comment.May 14 2017, 8:33 PM

Thanks, committing to master would be fine with me. While there should
be no change in behaviour with this patch at all (apart from fewer
compiler warnings), this seems like the least risky option.

This revision was automatically updated to reflect the committed changes.