as showEvent is too soon, create the plasma surface on
:Expose event, and reposition the surface
Details
- Reviewers
davidedmundson - Group Reviewers
Plasma Plasma on Wayland - Commits
- R120:d3bdb8d657ba: workaround for correct wayland positioning
krunner is correctly positioned with correct blur and shadows
Diff Detail
- Repository
- R120 Plasma Workspace
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
I assume this are adjustments for Qt 5.8 or later. How does this work with Qt 5.7? I fear if we change like this we are going to break Qt 5.7.
krunner/view.cpp | ||
---|---|---|
217 | what? |
I assume this are adjustments for Qt 5.8 or later. How does this work with Qt 5.7? I fear if we change like this we are going to break Qt 5.7.
Yes, in combination with the other two. There's some notes on T6064.
It's a valid fear, I also have a Qt 5.7 machine to test against and we won't be merging anything whilst it has a negative side effect.
krunner/view.cpp | ||
---|---|---|
247 | no, it doesn-t seem. |
Is it tested on X, Qt 5.7 as well as Qt 5.9
If you want me to do any of those, just ask.
krunner/view.cpp | ||
---|---|---|
250 | we need m_plasmaShellSurface = nullptr; this leaves a dangling pointer, which is both dangerous but also means we won't re-create it in ExposeEvent, I would have assumed that would mean the second show won't work. |
edit, ignore that last comment. I hadn't seen it was a QPointer.
Just my comment about checking on all other plaforms remains.