This patch adds a pid event to the plasma window management protocol. It
allows the compositor to tell allow a mapping between windows and processes.
Bumps the version number of the interface to 8 to indicate this.
hein | |
graesslin |
Plasma |
This patch adds a pid event to the plasma window management protocol. It
allows the compositor to tell allow a mapping between windows and processes.
Bumps the version number of the interface to 8 to indicate this.
autotest added, passed
No Linters Available |
No Unit Test Coverage |
src/client/protocols/plasma-window-management.xml | ||
---|---|---|
267 | uint is a native type: https://wayland.freedesktop.org/docs/html/ch04.html#sect-Protocol-Wire-Format you don't need to do an implicit cast |
Address review comments
src/client/plasmawindowmodel.cpp | ||
---|---|---|
84–86 | I consider it as impossible that the PID changes. |
autotests/client/test_plasma_window_model.cpp | ||
---|---|---|
215 | Please extend this |
Who is going to be setting this pid? Because note that containerized applications don't know their own pid (see kdbusaddons & knotifications patches for big shrug).
$ docker run ubuntu:17.04 pidof pidof 1 $ pidof pidof 6940
Can reproduce the failing test locally. Please fix ASAP! Broken tests is not acceptable in KWayland. This change has been on review so long, I find it quite disappointing that it was pushed without checking whether the tests work.
FWIW I did run make test on an earlier revision of the patch during the sprint while doing work on top of it; it must have regressed after.