Differential D5728

Release the wl_registry before QPA shutdown in QStyl
AbandonedPublic
Actions

Authored by davidedmundson on May 6 2017, 12:03 PM.

Details

Reviewers
hpereiradacosta
Group Reviewers
Plasma
Summary

Otherwise we get a double release as the QPA releases the wl_display
which deletes the registry.

BUG:

Diff Detail

Repository
R31 Breeze
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
davidedmundson created this revision.May 6 2017, 12:03 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMay 6 2017, 12:03 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson abandoned this revision.May 6 2017, 12:12 PM
cfeck added a reviewer: hpereiradacosta.May 6 2017, 12:20 PM
cfeck added a subscriber: cfeck.

Probably needs a similar fix in Oxygen. And if "Registry" is related to pixmap/tile caches, it might even fix the shutdown crashes we got there, e.g. bug 331260.

davidedmundson added a comment.May 6 2017, 12:24 PM

I uploaded to make it easier for someone to test a patch. It didn't work. That's why I'm closing it.

graesslin added a subscriber: graesslin.May 6 2017, 12:26 PM

I had already investigated the problem, pushed a change and reverted it. I think the qstyle gets destroyed too early.

Revision Contents
Changeset List

PathPackages
Mkstyle/breezeshadowhelper.cpp (3 lines)

Diff 14201

View Options

kstyle/breezeshadowhelper.cpp

Loading...