Disable create form while creating new accounts
ClosedPublic

Authored by elvisangelaccio on May 6 2017, 11:49 AM.

Details

Summary

When adding a new account in the KCM, it can take a while from the click
on the provider's button to the moment the window is presented to the user.
For example this happens with Google accounts, since we need to wait for
webkit plus the authentication page from Google.

To be sure that the users don't click twice the buttons while they are
waiting, disable the whole form and re-enable it later when the
authentication is done.

Diff Detail

Repository
R155 KAccounts Integration
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
  • Add this as receiver in the connect() call, otherwise there is a crash if we close the System Setting window before the Webkit window.
mck182 edited edge metadata.May 8 2017, 2:45 PM

I think this could also use some loading
indicator? Like the busy widget or at least
some label somewhere saying "Please wait"?

That would be good, yes. But we can't add new strings on the stable branch... shall we fix this on master only?

mck182 added a comment.May 8 2017, 3:05 PM

Well, technically you cannot add new strings only
and new features only, adding the busy spinner
would be ok as it's a fix for a bug.

If you want to use the string, then let's push this
patch to stable and fix with the string in master,
if you want the busy widget only, I think that's
fine for stable too.

  • Add progressbar for better feedback

Ping?

I'll push this soonish unless there are objections.

This revision was automatically updated to reflect the committed changes.