DBusMenuImporter: Use unique connection for QMenu::aboutToHide
ClosedPublic

Authored by drosca on May 3 2017, 8:10 PM.

Details

Summary

Otherwise the signal is sent multiple times.

Test Plan

Only one aboutToHide is received in apps

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
drosca created this revision.May 3 2017, 8:10 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMay 3 2017, 8:10 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
sebas added a subscriber: sebas.May 5 2017, 8:07 AM

This should be fairly easy to autotest, maybe it's a good opportunity to start them on this smal lib.

That said, the code is a copy of an upstream lib, so patching it locally (in plasma-workspace) leaves us with the risk that the patch gets lost once we remove this copy again and use upstream.

David can probably comment on the strategy here?

davidedmundson accepted this revision.May 5 2017, 8:08 AM
This revision is now accepted and ready to land.May 5 2017, 8:08 AM
This revision was automatically updated to reflect the committed changes.