When volume is above the maximum volume set in applet, moving the volume
slider will only lower it to the maximum applet volume.
This change automatically raises maximum volume when over defined
maximum volume (eg. when the volume is set by other volume control app
or when set by the applications itself like VLC), so it is possible to
control volume over the defined maximum value without first raising maximum volume.
Details
Details
Raised volume over 100% in VLC, applet automatically raised max volume for the stream.
Lowered the volume to 100%, stream in applet went back to global maximum volume.
Diff Detail
Diff Detail
- Repository
- R115 Plasma Audio Volume Applet
- Branch
- auto-raise-volume (branched from master)
- Lint
No Linters Available - Unit
No Unit Test Coverage
Comment Actions
Hmmm, this seems better than my solution since mine stays in the boosted state (slide.maxValue=150%) after the volume when back below 100%.
I'm guessing the side effect of this method is that if you uncheck "force boost" when the volume is 150%, it will stay at 150% volume until you manually slide it down to below 100%? If it does, wouldn't it then set the slider.maxValue to 100%, causing the volume to jump from 100% down to 66% (since you'd be 1/3 of the way down the slider when the max jumps from 150% to 100%).
If that does happen, we probably need a if (!forced && volume > 100%) volume = 100% when you uncheck it.
Comment Actions
You're right, forgot to submit the cosmetical comment.
| applet/contents/ui/ListItemBase.qml | ||
|---|---|---|
| 282 | Should be "volume", since that's the property. Or perhaps we don't need "volume" or "Volume". | |
| applet/contents/ui/ListItemBase.qml | ||
|---|---|---|
| 282 | "Volume" is a role from the model, so assigning to the "volume" property instead only makes it go through one indirection level. The "volume" property should be made readonly as it is there only for property changes. | |