activate all suitable launchers instead of only the first encountered
AbandonedPublic

Authored by sitter on May 3 2017, 9:47 AM.

Details

Reviewers
None
Group Reviewers
Plasma
Summary

When using multiple screens, each with a default panel and thus a launcher
of their own activating only one launcher makes no sense. We do no know
which screen the user is looking at so we cannot open the most relevant
menu at which point simply opening all would be the best solution.

In fact, opening all seems the most reasonable thing to do in all
circumstances, given we also do not know which menu the user wants to open
in a single-screen setup with multiple menus. Otherwise we'd be opening
an inconsistent (potentially wrong) one as the first-encountered launcher,
which may not be the previous first-encountered one, suddenly changing
behavior after a reboot.

To that end also debug when we do not activate a launcher as otherwise it
is hard to find out why launcher A gets activated but launcher B does not
so supports and advanced users have a chance to figure out why things are
going wrong.

Test Plan

opens all launchers now

Diff Detail

Repository
R120 Plasma Workspace
Branch
Plasma/5.9
Lint
No Linters Available
Unit
No Unit Test Coverage
sitter created this revision.May 3 2017, 9:47 AM
Restricted Application added a project: Plasma. · View Herald TranscriptMay 3 2017, 9:47 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

as the one who implemented this, I have to say that I disagree with the argumentation. I think it is wrong to activate all and fear that this could result in annoying issues especially as launchers close when losing focus. This could result in random launcher activating.

mart added a subscriber: mart.May 3 2017, 10:19 AM

-1 for activating all as well.
I think it should try to find first a launcher on the same screen the window with focus belongs, and the current random first if not found

How to get the current screen number of the screen with the focused window?

mart added a comment.May 3 2017, 10:40 AM

i fear it would need to use libtaskmanager directly, that can make things quite complicated :/

mart added a comment.May 3 2017, 10:46 AM

unless we add some kind of "activescreen" extension to the plasma shell wayand protocol..
(and i guess do an x11 fallback based upon kwindowsystem)

sitter abandoned this revision.May 3 2017, 10:54 AM

Ah well.