Annotation bar tooltips: align labels and content, make labels bold
ClosedPublic
Actions

Authored by kossebau on May 2 2017, 2:27 PM.

Details

Reviewers

apol
kfunk

Group Reviewers

KDevelop

Commits

R33:66d19b7b0623: Annotation bar tooltips: align labels and content, make labels bold
R32:66d19b7b0623: Annotation bar tooltips: align labels and content, make labels bold

Diff Detail

Repository

R33 KDevPlatform

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

kossebau created this revision.May 2 2017, 2:27 PM

Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptMay 2 2017, 2:27 PM

Looks like this then:

LGTM in general. One issue I can see: Won't work with Right-To-Left languages. Any idea how to properly support them without putting the whole HTML table into i18n(...)...?

Easy to test RTL languages, btw:
kdevelop -reverse

respect RTL languages

This revision is now accepted and ready to land.May 2 2017, 9:54 PM

Phew, complex. But looks fine.

Closed by commit R33:66d19b7b0623: Annotation bar tooltips: align labels and content, make labels bold (authored by kossebau). · Explain WhyMay 2 2017, 10:13 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			vcs/models/vcsannotationmodel.cpp (38 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	14081	59c652c		May 2 2017, 2:27 PM	★	★
Diff 2	14097	59c652c	respect RTL languages	May 2 2017, 7:47 PM	★	★
Diff 3	14101	59c652c	R33:66d19b7b0623a65923b907e3cee84f03a1028899	May 2 2017, 10:13 PM	★	★

Diff 14101

View Options

vcs/models/vcsannotationmodel.cpp