Differential D5679

fix autoscroll for Logger
ClosedPublic
Actions

Authored by aherlas on May 1 2017, 12:42 PM.

Details

Reviewers
None
Group Reviewers
Umbrello
Commits
R139:7662598f246f: fix autoscroll for Logger
Summary

Logger was not autoscrolling

Test Plan

Logger was not autoscrolling

Diff Detail

Repository
R139 Umbrello
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
aherlas created this revision.May 1 2017, 12:42 PM
aherlas added a reviewer: Umbrello.
habacker added a subscriber: habacker.Aug 6 2017, 10:20 PM

Have you checked how this will slow down importing a big code base ?

umbrello/codeimpwizard/codeimpstatuspage.cpp
144

Why do you changed this ? Did <br> not work ?

146

Why do you mix \n and <br> ?

147

indentition issue - no space before '('

aherlas added a comment.Aug 12 2017, 6:07 PM

I have checked it by importing a big code such as Source Game Engine.
I haven't notice any difference after the change, but the fact that the logger is better displayed and the output wasn't destroy each time I was clicking on the logger window output.

umbrello/codeimpwizard/codeimpstatuspage.cpp
144

Needed an extra EOL in order to display the information properly.

146

Line 289 has also a mix between \n and <br>, did you notice?

147

my mistake, I will correct it.

Closed by commit R139:7662598f246f: fix autoscroll for Logger (authored by habacker). · Explain WhyDec 14 2017, 9:05 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 23938

View Options

umbrello/codeimpwizard/codeimpstatuspage.cpp

Loading...