StreamRestore: Don't write unnecessary changes
ClosedPublic

Authored by drosca on Apr 29 2017, 4:46 PM.

Details

Summary

Applet updates mute state with every volume change - it does
writeChanges(volume) immediately following with writeChanges(mute)
and it seems to make PulseAudio to ignore the volume change.
This makes sure that writeChanges() is only called when something really
changed.

BUG: 367688
FIXED-IN: 5.10.0

Test Plan

I can't reproduce the issue myself, but it was confirmed in bugreport
that this patch fixes the issue.

Diff Detail

Repository
R115 Plasma Audio Volume Applet
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
drosca created this revision.Apr 29 2017, 4:46 PM
Restricted Application added a project: Plasma. · View Herald TranscriptApr 29 2017, 4:46 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson accepted this revision.Apr 29 2017, 8:59 PM
This revision is now accepted and ready to land.Apr 29 2017, 8:59 PM
This revision was automatically updated to reflect the committed changes.