Avoid KDirWatch problem not stopping watching a dir when told
ClosedPublic

Authored by mkoller on Apr 29 2017, 12:12 PM.

Details

Summary

According to KDirWatch docs, it should no longer emit the dirty signal when told to KDirWatch::stopDirScan(dir);
However it does.
This fix avoids intermittent synchronize collection calls during this maildir resource creates the mail files it just received.

Diff Detail

Repository
R44 KDE PIM Runtime
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mkoller created this revision.Apr 29 2017, 12:12 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptApr 29 2017, 12:12 PM
Restricted Application added a subscriber: KDE PIM. · View Herald Transcript
dvratil accepted this revision.Apr 29 2017, 2:59 PM
dvratil added a subscriber: dvratil.

Remove/add has a bigger overhead than stop/start. Do you have a KDirWatch bug report/test case? Would be cool if it could be referenced from here or from the commit so we can revert back once it's fixed in Frameworks.

This revision is now accepted and ready to land.Apr 29 2017, 2:59 PM

Yes, I have a testprogram, which I posted on kde-frameworks-devel@kde.org and kde-core-devel@kde.org asking if I'm doing something wrong or this is
the expected behavior - no response ...
I now created a bugreport with my test program
https://bugs.kde.org/show_bug.cgi?id=379359

This revision was automatically updated to reflect the committed changes.