Use consistent icon names for build stuff, remove left-over legacy icons
ClosedPublic

Authored by kossebau on Apr 29 2017, 11:42 AM.

Details

Summary

From the commit history "run-clean" and "run-build" were introduced in
2008 in kdevplatform (d2dbb08e69c46517b5ed0ee471069e051029b10a).
August 2009 Oxygen then added similar icons in August 2008
(https://websvn.kde.org/?view=revision&revision=1010233)
but with the name "run-build-clean" and "run-build-install".

September 2009 then sees kdevplatform adding use of also
"run-build-clean" and "run-build-install" (dd4a7f9e514d58c7b787c7c3e11bfb70a056092c)
without adding own hicolor icons.

Given the icon use-cases and the fact that both icon sets Oxygen and Breeze
have "run-clean" and "run-install" sym-linked to "run-build-install"
and "run-build-clean", there seems no need to keep the old variants,
and thus also no more need to keep the legacy hicolor icons as
currently needed due to Oxygen icons 5.18 (cmp. min KF5 dep of kdevplatform)
not yet having support for that name.

Diff Detail

Repository
R33 KDevPlatform
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kossebau created this revision.Apr 29 2017, 11:42 AM
Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptApr 29 2017, 11:42 AM
apol accepted this revision.Apr 30 2017, 12:21 AM
apol added a subscriber: apol.

You rock, man! :)

This revision is now accepted and ready to land.Apr 30 2017, 12:21 AM
This revision was automatically updated to reflect the committed changes.