Differential D5643

Improve protocol debug output by adding timestamp and tag
ClosedPublic
Actions

Authored by mkoller on Apr 28 2017, 4:42 PM.

Details

Reviewers
dvratil
Commits
R165:ad5a5a3f65bd: Improve protocol debug output by adding timestamp and tag
Summary

For analyzing several logfiles in parallel it is crucial to see an exact timestamp. This adds it with milliseconds resolution

Diff Detail

Repository
R165 Akonadi
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mkoller created this revision.Apr 28 2017, 4:42 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptApr 28 2017, 4:42 PM
Restricted Application added a subscriber: KDE PIM. · View Herald Transcript
dvratil requested changes to this revision.Apr 28 2017, 6:19 PM

Good idea. I think it would be better to first print the timestamp, then the tag number though, since the tag is part of the command, but the timestamp is part of the log.

src/core/connection.cpp
226

Use QStringLiteral instead of QLatin1String, and maybe use a better date format? yyyy-MM-dd (ISO) or dd.MM.yyyy (European).

Same below for the client messages.

This revision now requires changes to proceed.Apr 28 2017, 6:19 PM
mkoller updated this revision to Diff 13961.Apr 29 2017, 11:45 AM
mkoller edited edge metadata.
dvratil accepted this revision.Apr 29 2017, 2:54 PM

Thanks!

This revision is now accepted and ready to land.Apr 29 2017, 2:54 PM
Closed by commit R165:ad5a5a3f65bd: Improve protocol debug output by adding timestamp and tag (authored by mkoller). · Explain WhyApr 29 2017, 3:04 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/core/connection.cpp (13 lines)

Diff 13995

View Options

src/core/connection.cpp

Loading...