Differential D5630

Use Qt to create the autostart entry instead of system calls
ClosedPublic
Actions

Authored by ltoscano on Apr 28 2017, 7:27 AM.

Details

Reviewers
whiting
Commits
R429:bc247307e1df: Use Qt to create the autostart entry instead of system calls
Summary

Probably the code predates QFile?

Test Plan

The symlinks is created and removed as expected (and seen
by kcm_autostart).

Diff Detail

Repository
R429 KMouseTool
Branch
frameworks
Lint
No Linters Available
Unit
No Unit Test Coverage
ltoscano created this revision.Apr 28 2017, 7:27 AM
ltoscano added a comment.Apr 28 2017, 7:29 AM

Please note that I wrote this against the frameworks version, but I suspect that it would work against the Qt4 version.
If we are going to ship the Qt5 version of kmousetool in Applications 17.08 (which I would recommend, as it seems to work), then this can go directly to frameworks, otherwise let's re-target to master,

whiting edited edge metadata.EditedJun 25 2017, 2:10 AM

Yes, this should go in the frameworks branch, I'll see if I can get the frameworks branch merged to master this week.

ltoscano added a comment.EditedJun 25 2017, 8:35 AM

And what about this review? I mean, if it's fine, can you please select "Approve"? :)

whiting accepted this revision.Jul 5 2017, 10:39 PM
This revision is now accepted and ready to land.Jul 5 2017, 10:39 PM
Closed by commit R429:bc247307e1df: Use Qt to create the autostart entry instead of system calls (authored by ltoscano). · Explain WhyJul 5 2017, 10:40 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mkmousetool/kmousetool.cpp (5 lines)

Diff 13902

View Options

kmousetool/kmousetool.cpp

Loading...