Initial cleanup of the debug statements (qDebug, dbk, dbe)
ClosedPublic

Authored by ltoscano on Apr 27 2017, 10:03 PM.

Details

Summary

There was a combination of qDebug, kDebug and custom macros
which redirected to qDebug, standard error or standard output.

This is the first attempt to unify all of the above with the usage
of Qt categorized logging. Fixed in the patch:

  • direct usage of qDebug;
  • kDebug though the dbk macro;
  • standard error through the dbe macro.

The levels for dbk/dbe messages have been aligned with the level
of the respective macros.
Few standard output/dbo macros have been cleaned as well, but many
are still used. At least their usage is confined to one file only
(src/generator/sudokuboard.cpp). Some of those messages produces
formatted output, so they may require overloads of the << operator,
if they need to be kept.

Test Plan

Compiles.

Diff Detail

Repository
R417 KSudoku
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ltoscano created this revision.Apr 27 2017, 10:03 PM
Restricted Application added a reviewer: KDE Games. · View Herald TranscriptApr 27 2017, 10:03 PM
Restricted Application added a subscriber: KDE Games. · View Herald Transcript
stikonas accepted this revision.Apr 27 2017, 10:46 PM
This revision is now accepted and ready to land.Apr 27 2017, 10:46 PM
This revision was automatically updated to reflect the committed changes.