Adding an option to show popular documents/apps for Kickoff

Authored by ivan on Apr 27 2017, 2:43 PM.


Diff Detail

R119 Plasma Desktop
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
ivan created this revision.Apr 27 2017, 2:43 PM
Restricted Application added a project: Plasma. · View Herald TranscriptApr 27 2017, 2:43 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ivan added a reviewer: sebas.May 2 2017, 7:36 AM
hein accepted this revision.May 2 2017, 7:37 AM

Code looks good to me and I tested an earlier version of the patch and contributed the QQmlParserStatus hits. But sebas should chime in on the UI side. I alo didn't test this revision due to holiday/travel.

This revision is now accepted and ready to land.May 2 2017, 7:37 AM
hein added a comment.May 5 2017, 9:13 PM

We discussed this at a dev sprint locally and I think the idea is we don't have both tabs on by default or something ... Marco?

ivan added a comment.May 6 2017, 4:40 AM

They are not both on - oftenUsed:f

mart edited edge metadata.May 6 2017, 8:32 AM

yes, the idea is to have only the popular documents tab by default in 5.11, then the history one can still be manualy enabled by the user

hein added a comment.May 6 2017, 8:42 AM

Sounds good to me ... bit worried about people missing their history though, we might get some angry feedback.

ivan added a comment.May 6 2017, 4:16 PM

Not sure I'd rush it for 5.11. I'll probably have to tweak the formula coefficients for the score - how much deterioration over time it should have, ... (this is the main reason I'm making the graphs - to be able to easier debug the stats - having it in a user application is less important.

This revision was automatically updated to reflect the committed changes.