Revert "launch autostart apps in ksmserver using KRun, not QProcess" KRun::runApplication will show blocking error dialogs if it fails to find the executable This means we don't autostart the next app, which could be fatal if it comes before...
ClosedPublic

Authored by davidedmundson on Apr 27 2017, 1:53 PM.

Details

Summary

...kwin/plasma
We shouldn't be having blocking calls in ksmserver it can deadlock
And even in the best case we'd still end up blocking ksplash for 30 seconds

We then port to KProcess which was part of the motivation behind the patch as it
has better stdout handling

This reverts commit 0f19e92f3e85d064de9cebf280fa8e085485c2e0.

BUG: 379254

Port autostarting applications to KProcess
It has better stdout handling

Test Plan

Logged in, still got my main session

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson created this revision.Apr 27 2017, 1:53 PM
Restricted Application added a project: Plasma. · View Herald TranscriptApr 27 2017, 1:53 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mart accepted this revision.Apr 27 2017, 2:01 PM
This revision is now accepted and ready to land.Apr 27 2017, 2:01 PM
This revision was automatically updated to reflect the committed changes.