fix include path in KF5PackageMacros.cmake
AbandonedPublic

Authored by jriddell on Apr 27 2017, 10:29 AM.

Details

Reviewers
mart
Group Reviewers
Frameworks
Summary

KF5PackageMacros.cmake uses ECM without setting the include path so it can't be found. This isn't usually seen as usually something else will set the path before this.

http://build.neon.kde.org/job/xenial_unstable_frameworks_kpackage_lintcmake/2/console

Test Plan

minimal cmakelists file which includes this file

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped
jriddell created this revision.Apr 27 2017, 10:29 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptApr 27 2017, 10:29 AM
apol added a subscriber: apol.Apr 27 2017, 10:46 AM
apol added inline comments.
KF5PackageMacros.cmake
3

How about include(${ECM_KDE_MODULE_DIR}/KDEInstallDirs)?
This way we don't mess with CMAKE_MODULE_PATH.

jriddell updated this revision to Diff 13865.Apr 27 2017, 10:56 AM

without changing include path

works if I add a .cmake to the end of the include() value

jriddell abandoned this revision.Apr 27 2017, 12:36 PM

submitted