revert the hackish overriding of Client::desktop() for session saving
ClosedPublic

Authored by lunakl on Apr 27 2017, 10:24 AM.

Details

Summary

The member variable is not what determines which desktop a window is on,
it's more like caching the state. Therefore trying to fake a new value
eventually leads to inconsistencies, e.g. having KWrite open with unsaved
changes on inactive desktop results in the window ending up on all desktops
after session save (both successful and cancelled).
This pretty much reverts the whole 7ce380497f that introduced this and also
a0a976885c2 that tried to fix some of the problems resulting from it.
The original problem of session saving of windows of inactive activities still
remains, to be fixed by another commit.

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
lunakl created this revision.Apr 27 2017, 10:24 AM
Restricted Application added a project: KWin. · View Herald TranscriptApr 27 2017, 10:24 AM
Restricted Application added a subscriber: kwin. · View Herald Transcript
graesslin accepted this revision.May 8 2017, 4:29 PM
This revision is now accepted and ready to land.May 8 2017, 4:29 PM
This revision was automatically updated to reflect the committed changes.