Configurable icon size in vertical panels

Authored by hein on Apr 26 2017, 10:58 AM.


Group Reviewers
R119:ad08c43ccaa2: Configurable icon size

Vertical panels are special: While horizontal panels are generally
almost always only used in configurations ranging from one to three
text lines in height, vertical panels are used in a wider range
from very narrow to very wide, depending on whether users want to
fit only icons or also text (which needs ample horizontal space to
be useful).

In a wide vertical panel, it's inappropriate for launcher icons to
grow beyond a certan size, as they otherwise occupy too much
vertical space. For that reason D4550 introduced an icon size setting
in the Task Manager applet, shown only when the applet is embedded
into a vertical panel.

This patch brings the same setting to Kicker and App Dash, with the
same smallMedium default. A narrow vertical panel which doesn't fit
text labels or uses Icons-only Task Manager will therefore get same-
sized icons in those launchers and in the TM. A wider vertical panel
won't see the launcher icon grow beyond the TM's icon size if both
are left as default, with settings allowing users to manage the two


A similar change will need to be done for Kickoff, which uses the
default CompactRepr instead.

Diff Detail

R119 Plasma Desktop
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
hein created this revision.Apr 26 2017, 10:58 AM
Restricted Application added a project: Plasma. · View Herald TranscriptApr 26 2017, 10:58 AM
mart edited edge metadata.Apr 26 2017, 11:13 AM

I am not sure there should be difference between kicker and other applets that look like an icon (like icon plasmoid or those that are normally in the systray but can live also outside it)

I would like a global option for all icon-looking plasmoids in panels.. even tough i wouldn't know where to put the ui for such an option

hein added a comment.Apr 26 2017, 11:24 AM

As per the IRC convo we're going to resurrect the "Panel" icon size from he Icons->Advanced KCM to use as ceiling for the various icon-type panel reprs. I'll update this when the API is in place.

hein updated this revision to Diff 13812.Apr 26 2017, 11:43 AM

Use the new units.iconSizeHints.panel instead.

mart added a comment.Apr 26 2017, 11:47 AM

I think this should be done also in

hein updated this revision to Diff 13814.Apr 26 2017, 11:49 AM

Restrict to panels.

mart accepted this revision.Apr 26 2017, 11:54 AM
This revision is now accepted and ready to land.Apr 26 2017, 11:54 AM
hein updated this revision to Diff 13816.Apr 26 2017, 11:55 AM

Fix commit subject.

This revision was automatically updated to reflect the committed changes.