Differential D5590

Fix find_dependency: REQUIRED isn't allowed
ClosedPublic
Actions

Authored by jriddell on Apr 26 2017, 10:29 AM.

Details

Reviewers
staniek
Group Reviewers
KEXI
Commits
R14:434aa3da9428: Fix find_dependency: REQUIRED isn't allowed
Summary

REQUIRED isn't allowed in find_dependency
https://cmake.org/cmake/help/v3.0/module/CMakeFindDependencyMacro.html
this cmake file breaks if tried to use
http://build.neon.kde.org/job/xenial_stable_calligra_kreport_lintcmake/2/consoleFull

TRIVIAL

Diff Detail

Repository
R14 KReport
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
jriddell created this revision.Apr 26 2017, 10:29 AM
Restricted Application added a project: KEXI. · View Herald TranscriptApr 26 2017, 10:29 AM
staniek retitled this revision from fix cmake file to Fix find_dependency: REQUIRED isn't allowed.Apr 26 2017, 10:43 AM
staniek edited the summary of this revision. (Show Details)
staniek accepted this revision.Apr 26 2017, 10:50 AM
This revision is now accepted and ready to land.Apr 26 2017, 10:50 AM
Closed by commit R14:434aa3da9428: Fix find_dependency: REQUIRED isn't allowed (authored by jriddell, committed by staniek). · Explain WhyApr 26 2017, 10:53 AM
This revision was automatically updated to reflect the committed changes.
staniek added a comment.Apr 26 2017, 12:01 PM

Thanks Jonathan.

Revision Contents
Changeset List

PathPackages
Msrc/KReportConfig.cmake.in (6 lines)

Diff 13808

View Options

src/KReportConfig.cmake.in

Loading...