Differential D559

move descicion of process/render futher up
ClosedPublic
Actions

Authored by knauss on Nov 19 2015, 9:36 AM.

Details

Reviewers
vkrause
Group Reviewers
KDE PIM
Maniphest Tasks
T719: Refactor objecttreeparser
Commits
R94:7179ff5a1cc7: move descicion of process/render futher up
Summary

restructure defaultHandling to use MessageParts

Diff Detail

Repository
R43 KDE PIM
Lint
No Linters Available
Unit
No Unit Test Coverage
knauss updated this revision to Diff 1325.Nov 19 2015, 9:36 AM
knauss retitled this revision from to move descicion of process/render futher up.
knauss updated this object.
knauss edited the test plan for this revision. (Show Details)
knauss added a reviewer: vkrause.
vkrause edited edge metadata.Nov 21 2015, 11:34 AM

looks good in general

messageviewer/src/viewer/objecttreeparser.cpp
928

intentionally commented out code?

knauss added inline comments.Nov 23 2015, 12:47 AM
messageviewer/src/viewer/objecttreeparser.cpp
928

Yepp this is intentenally.
It is a bahaviour change at the moment, but I have already processMailmanMessage working with process/render. This was my first test baloon to test multiple Formatters for one mime type. Will upload the new patches tomorrow.

vkrause accepted this revision.Dec 5 2015, 10:41 AM
vkrause edited edge metadata.
This revision is now accepted and ready to land.Dec 5 2015, 10:42 AM
knauss closed this revision.Jan 12 2016, 7:36 PM

Revision Contents
Changeset List

Diff 1325

View Options

messageviewer/src/viewer/bodypartformatter.cpp

Loading...
View Options

messageviewer/src/viewer/objecttreeparser.h

Loading...
View Options

messageviewer/src/viewer/objecttreeparser.cpp

Loading...