[TaskGroupingProxyModel] Use LauncherUrlWithoutIcon
ClosedPublic

Authored by broulik on Apr 25 2017, 2:56 PM.

Details

Summary

We manually remove the query anyway, so the icon can never be a part of the URL.

Test Plan

Forcing grouping/ungrouping still works, it also still knows blacklistings I added before this change.

Whenever we used LauncherUrl we wither did RemoveQuery and we also told TaskTools::launcherUrlsMatch to IgnoreQueryItems

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Apr 25 2017, 2:56 PM
Restricted Application added a project: Plasma. · View Herald TranscriptApr 25 2017, 2:56 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik edited the test plan for this revision. (Show Details)Apr 25 2017, 2:58 PM
hein accepted this revision.Apr 26 2017, 7:35 AM

Good cleanup :)

This revision is now accepted and ready to land.Apr 26 2017, 7:35 AM
This revision was automatically updated to reflect the committed changes.