Man ioslave: Port away from KDELibs4Support
ClosedPublic
Actions

Authored by marten on Apr 24 2017, 3:11 PM.

Details

Reviewers

dfaure
mart

Group Reviewers

Plasma

Commits

Summary

This change removes the build and runtime requirement for KDELibs4Support from the man ioslave and the man2html converter.

Test Plan

Built kio-extras with this change, checked correct operation of ioslave and man page generation/display.

Repository

R320 KIO Extras

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

mart accepted this revision.May 5 2017, 2:48 PM

This revision is now accepted and ready to land.May 5 2017, 2:48 PM

This revision was automatically updated to reflect the committed changes.

man/kio_man.cpp
247	keep the spaces around !=
man/man2html.cpp
6014	remove "KDE", you can't version a community ;)
6015	why PLASMA? This is kde/kdenetwork/kio-extras, usable outside of a plasma workspace. I'm curious where PLASMA_VERSION_STRING even comes from !?

man/kio_man.cpp
247	Will fix.
man/man2html.cpp
6015	This was originally the closest thing I could find to the "KDE" version available. However, it's been pointed out that it makes kio-extras depend on Plasma, and I've now changed it to take the version from the project version of kio-extras itself. There doesn't really seem to be much point in displaying this information at all, so if you think it would be worthwhile I'll remove the entire "KDE version" string (i.e. act as if SIMPLE_MAN2HTML was defined above). Not sure whether the number/string registers defined about lines 297 and 1513 above are ever used in any man pages, though, but if they are no use they could be cut out as well.