Differential D553

start with smime refactor
AbandonedPublic
Actions

Authored by knauss on Nov 19 2015, 9:30 AM.

Details

Reviewers
vkrause
Group Reviewers
KDE PIM
Maniphest Tasks
T719: Refactor objecttreeparser
Commits
R94:9b29e79c86d1: delete unused logic in smime function.

Diff Detail

Repository
R43 KDE PIM
Lint
No Linters Available
Unit
No Unit Test Coverage
knauss updated this revision to Diff 1319.Nov 19 2015, 9:30 AM
knauss retitled this revision from to start with smime refactor.
knauss added a reviewer: vkrause.
knauss added a reviewer: KDE PIM.Nov 19 2015, 9:42 AM
knauss added a project: KDE PIM.
vkrause edited edge metadata.Nov 21 2015, 11:35 AM

just deletes code, not what I would expect for "refactoring" ;) if that's intentional, you might want to change the commit message slightly

knauss added a comment.Nov 23 2015, 12:50 AM

Well the rest of the function is already ready refactored with MessagePart, so this was the small rest. And this logic is never called and should be placed into the CryptoMessagePart if needed.

Will update the commit message.

knauss abandoned this revision.Feb 9 2016, 5:34 PM

already commited , but can close it because it wasn't accpeted

Revision Contents
Changeset List

Diff 1319

View Options

messageviewer/src/viewer/objecttreeparser.cpp

Loading...