Dock based interface, Create a status bar.
ClosedPublic

Authored by rizzitello on Apr 20 2017, 9:38 PM.

Details

Summary

This the is the general design I have in mind for atelier adapted to the test client .
The gui now uses serveral QDockWidgets to hold the various controls and also contains a status bar with some basic info like atcore state and the printLayout has also been moved to the status bar. The gui now also contains one menu view , where you can toggle the docks visibility (incase you close one you want to open again) .

UPDATE:
ToDo before merging.

  • Fix View Menu (see test plan update)
  • Remove the settings menu . We dont want the user to hide the status bar and we don't provide any action for ShortCut or Toolbars
  • Action to show /hide the dock handles

UPDATE 2 :Ready for merge

Test Plan

The only issues with this gui is that when i connect the docks visibilityChanged to the actions setChecked and the actions toggled to the docks setVisibility you lose the ability to tabify them since when they are not the active tabified dock they close because of the toggle of the action. Something is wrong in how im doing this menu and that needs to be fixed before this can be merged. To see the behavior you need to uncomment the connects for the docks signal in testclient/mainwindow.cpp .

UPDATE:
This is better but not perfect with KXMLGui. Now the problem is that when tabified the items within the view menu are only check if the widget is the selected tab. This is much better then them disapearing but we still need to address this problem before merging this.

Diff Detail

Repository
R232 AtCore
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
rizzitello created this revision.Apr 20 2017, 9:38 PM
rizzitello edited the summary of this revision. (Show Details)Apr 20 2017, 9:51 PM
rizzitello edited the test plan for this revision. (Show Details)
patrickelectric requested changes to this revision.Apr 21 2017, 3:57 PM
patrickelectric added inline comments.
testclient/mainwindow.cpp
141

Remove commented code

This revision now requires changes to proceed.Apr 21 2017, 3:57 PM
rizzitello edited edge metadata.
rizzitello edited the test plan for this revision. (Show Details)
  • Dock based interface, Create a status bar.
  • Update items to work with KXMLGui
rizzitello edited the summary of this revision. (Show Details)Apr 21 2017, 11:16 PM
rizzitello edited the test plan for this revision. (Show Details)
rizzitello edited the summary of this revision. (Show Details)Apr 21 2017, 11:18 PM
rizzitello edited the summary of this revision. (Show Details)
rizzitello edited the test plan for this revision. (Show Details)
  • Update items to work with KXMLGui
laysrodrigues requested changes to this revision.Apr 23 2017, 9:37 PM

I liked, but before merge this we need to discover the fix for the problems that sith pointed out

This revision now requires changes to proceed.Apr 23 2017, 9:37 PM
patrickelectric edited edge metadata.
  • Correct RightDockWidgetArea position
rizzitello updated this revision to Diff 13925.Apr 28 2017, 2:19 PM
  • Dock based interface, Create a status bar.
  • Update items to work with KXMLGui
  • Remove the settings menu
rizzitello edited the summary of this revision. (Show Details)Apr 28 2017, 2:21 PM
rizzitello edited the test plan for this revision. (Show Details)
rizzitello edited the summary of this revision. (Show Details)
rizzitello edited the summary of this revision. (Show Details)Apr 28 2017, 2:23 PM
rizzitello edited the summary of this revision. (Show Details)
patrickelectric edited the test plan for this revision. (Show Details)
  • Correct RightDockWidgetArea position
  • Change all minimumSize param to 0
rizzitello updated this revision to Diff 13927.Apr 28 2017, 2:30 PM
  • Dock based interface, Create a status bar.
  • Update items to work with KXMLGui
  • Remove the settings menu
  • Rebase on master
  • Change all minimumSize param to 0
  • Correct RightDockWidgetArea position
  • Change all minimumSize param to 0
  • Correct RightDockWidgetArea position
rizzitello updated this revision to Diff 13936.Apr 28 2017, 3:21 PM
  • Fix the 'View' menu
rizzitello edited the summary of this revision. (Show Details)Apr 28 2017, 3:22 PM
  • Add new Action to show / hide the docks titlebars
  • Rebase to master
  • Add new Action to show / hide the docks titlebars
rizzitello edited the summary of this revision. (Show Details)Apr 28 2017, 11:27 PM
  • Add new Action to show / hide the docks titlebars
rizzitello updated this revision to Diff 13987.Apr 29 2017, 2:15 PM
  • Start with dock titlebars shown
patrickelectric accepted this revision.Apr 29 2017, 2:20 PM
laysrodrigues accepted this revision.Apr 29 2017, 2:35 PM
This revision is now accepted and ready to land.Apr 29 2017, 2:35 PM
This revision was automatically updated to reflect the committed changes.