add resize handles on all corners/sides
ClosedPublic

Authored by mart on Apr 20 2017, 3:40 PM.

Details

Summary

when the desktop is unlocked make plasmoids behave like windows
allowing resize from all corners changing the mouse cursor shape
accordingly

Test Plan

tried to resize in both normal and reverse layout

Diff Detail

Repository
R119 Plasma Desktop
Branch
arcpatch-D5527
Lint
No Linters Available
Unit
No Unit Test Coverage
mart created this revision.Apr 20 2017, 3:40 PM
Restricted Application added a project: Plasma. · View Herald TranscriptApr 20 2017, 3:40 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mart added a reviewer: hein.Apr 20 2017, 3:40 PM

10 years I have waited for this \o/

Isn't the resize button on the applet a bit redundant then? I wouldn't mind it staying so we keep a discoverable button for that but I'm wondering.
One down side is that it makes it harder to move applets, many you could drag around on their corners (without doing the press-and-hold dance).

Anyway, huge +1

mart added a comment.Apr 24 2017, 8:47 AM

10 years I have waited for this \o/

Isn't the resize button on the applet a bit redundant then? I wouldn't mind it staying so we keep a discoverable button for that but I'm wondering.
One down side is that it makes it harder to move applets, many you could drag around on their corners (without doing the press-and-hold dance).

Anyway, huge +1

I think i prefer keeping the handle as is, and still have an explicit resize button

broulik added inline comments.Apr 24 2017, 9:52 AM
containments/desktop/package/contents/ui/AppletAppearance.qml
609 ↗(On Diff #13650)

The handles should be hidden if widgets are locked, otherwise you get the cursors but cannot actually do anything.

mart updated this revision to Diff 13737.Apr 24 2017, 12:17 PM

hide handles when blocked and for applets w/o background

hein accepted this revision.Apr 24 2017, 12:19 PM
This revision is now accepted and ready to land.Apr 24 2017, 12:19 PM
broulik accepted this revision.Apr 24 2017, 12:20 PM
This revision was automatically updated to reflect the committed changes.

When you are in edit mode (clicking on toolbox), the handles on the right don't work.

Bug 3: Snapping to the grid is now wrong.

Before we would drag only from the right, so it would adjust the width to snap to the grid size. That works

Now we can drag from the left, when you resize something past the grid size, it will leave the left where you placed it, then resize to the right.
Meaning you can drag the left handle and it will end up moving to the right.


Shouldn't this *only* exist in edit mode?
Otherwise we'll end up with people moving plasmoids by resizing one corner then the other.

containments/desktop/package/contents/ui/ResizeHandle.qml
52 ↗(On Diff #13650)

Bug 2 - major

You've just broken all resizing on note plasmoids and analog clocks even when using the main handle.

I do not appreciate having my major bugs ignored.

I will be reverting this.
You can try again for 5.11.